The following document contains the results of PMD 5.2.1.
Files
org/nicepop/domain/App.java
| Violation |
Line |
| Comment is too large: Too many lines |
3–21 |
| Avoid short class names like App |
27–38 |
| All methods are static. Consider using a utility class instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. |
29–38 |
| publicMethodCommentRequirement Required |
30–37 |
| Consider using varargs for methods or constructors which take an array the last parameter. |
30 |
| Parameter 'args' is not assigned and could be declared final |
30 |
| System.out.println is used |
32 |
| A method should have only one exit point, and that should be the last statement in the method |
35 |
org/nicepop/domain/Dinner.java
| Violation |
Line |
| headerCommentRequirement Required |
3–9 |
| Parameter 'recipe' is not assigned and could be declared final |
5 |
| publicMethodCommentRequirement Required |
5–7 |
org/nicepop/domain/Meal.java
| Violation |
Line |
| Avoid short class names like Meal |
3–18 |
| headerCommentRequirement Required |
3–18 |
| fieldCommentRequirement Required |
5 |
| Parameter 'recipe' is not assigned and could be declared final |
7 |
| publicMethodCommentRequirement Required |
7–9 |
| publicMethodCommentRequirement Required |
11–13 |
| Parameter 'recipe' is not assigned and could be declared final |
15 |
| publicMethodCommentRequirement Required |
15–17 |
org/nicepop/domain/Product.java
| Violation |
Line |
| Comment is too large: Too many lines |
3–21 |
| headerCommentRequirement Required |
23–43 |
| fieldCommentRequirement Required |
27 |
| Parameter 'name' is not assigned and could be declared final |
29 |
| publicMethodCommentRequirement Required |
29–33 |
| Avoid empty block statements. |
31 |
| publicMethodCommentRequirement Required |
35–37 |
| Parameter 'name' is not assigned and could be declared final |
39 |
| publicMethodCommentRequirement Required |
39–41 |
org/nicepop/domain/Recipe.java
| Violation |
Line |
| Comment is too large: Too many lines |
3–21 |
| headerCommentRequirement Required |
26–53 |
| fieldCommentRequirement Required |
28 |
| fieldCommentRequirement Required |
29 |
| publicMethodCommentRequirement Required |
31–35 |
| Parameter 'version' is not assigned and could be declared final |
31 |
| Parameter 'products' is not assigned and could be declared final |
31 |
| publicMethodCommentRequirement Required |
37–39 |
| protectedMethodCommentRequirement Required |
41–43 |
| Parameter 'products' is not assigned and could be declared final |
41 |
| publicMethodCommentRequirement Required |
45–47 |
| protectedMethodCommentRequirement Required |
49–51 |
| Parameter 'version' is not assigned and could be declared final |
49 |